standards-compliant import.meta.resolve #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c5f7c97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ceb1ca2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-import-meta-resolve.agoric-sdk.pages.dev |
turadg
force-pushed
the
ta/import-meta-resolve
branch
from
283ab20 to
989eec8
Compare
turadg
force-pushed
the
ta/import-meta-resolve
branch
4 times, most recently
from
9660aa6 to
ce9ff09
Compare
kriskowal
approved these changes
Feb 13, 2025
| const importSpec = spec => | ||
| importMetaResolve(spec, import.meta.url).then(u => new URL(u).pathname); | ||
| const importSpec = async spec => | ||
| new URL(importMetaResolve(spec, import.meta.url)).pathname; |
There was a problem hiding this comment.
Not necessary to fix everything in one pass, but notably, this is an opportunity to replace .pathname with fileURLToPath as that’s more robust across platforms or checkout directories with spaces (.pathname will have %20 instead of the obligate space).
turadg
force-pushed
the
ta/import-meta-resolve
branch
from
ce9ff09 to
42b3213
Compare
turadg
force-pushed
the
ta/import-meta-resolve
branch
from
42b3213 to
c5f7c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10986
Description
import.meta.resolveis synchronous nowSecurity Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Kink to sort out with dapp integration test:
Upgrade Considerations